Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TopKAggregation rule into physical-optimizer crate #12334

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Move TopKAggregation rule into physical-optimizer crate #12334

merged 5 commits into from
Sep 6, 2024
+44 −29

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Sep 5, 2024

Which issue does this PR close?

part of #11502.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added optimizer Optimizer rules core Core DataFusion crate labels Sep 5, 2024
lewiszlw
lewiszlw commented Sep 5, 2024
View reviewed changes
datafusion-cli/Cargo.toml Outdated Show resolved Hide resolved
alamb
alamb reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw -- other than the MSRV change this looks great to me 🙏

alamb
alamb approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goo to me -- thank you @lewiszlw

@alamb alamb merged commit dd04929 into apache:main Sep 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewiszlw @alamb